Correct allow_null behaviour when required=False #5888
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #5639. There
required=False
would override the implicit default coming fromallow_null
, omitting the field from inclusion. This was incorrect, as reported in #5708.Closes #5708.
There's a slight BC issue here — although we're restoring an older behaviour. Overriding
data
to remove the offending field ifNone
would serve as a fallback.TODO: